[PATCH] [LLVM] [sanitizer] add conditionals for libc

[Bernhard Reutner-Fischer]

On 23 April 2014 10:57, Kostya Serebryany <kcc at google.com> wrote:
> The patch is huge and has too many ifdefs.
> It will have some time for us to review and will be very costly to maintain.

Why do you think it will be very costly to maintain?
These things (e.g. glob_t members) do not change between glibc-releases, so
i fail to see how this would be costly to maintain? It's pretty much a one-time
thing to do IMO.

> So, before we continue with review I would like to hear the motivation and

The motivation behind this patch is that there are libc's apart from glibc, and
these libc implementations, being POSIX compliant, may lack certain GNU
extensions (as implemented in glibc). As you can see in your own code, you
have gazillions of conditionals (preprocessor conditionals, which i add just add
a couple of more, generic ones, btw, to answer your comment from above) to
handle these other libc's.

The route this patch takes it to probe these non-standard things and
act accordingly.

> whether you are welling to help us maintain this code in future (= set up a public build bot)

I'm certainly willing to help maintain this code in the future since i
want to use
your nice sanitizers via gcc, sure. I cannot, however, setup a public
build-bot since
my notebook is not prepared to handle this task on a regular basis.
If you break stuff upstream and i find the backported gcc version to
be dysfunctional, i
will send you fixes if time permits.

I think the patch itself is pretty straight forward, please let me
know if you have specific
questions about a technical aspect of the patch.

Please apply.
thanks,
>
> http://reviews.llvm.org/D3464
>
>