[PATCH] MachineFunction is exposed to X86AsmParser.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Apr 22 11:06:39 PDT 2014

The phabricator login doesn't seem to be working, so I will just put
the comments on the email.

setMCTargetOptions is now unused, please delete it.
onMCTargetOptionsSet is also unused, please delete it.

AsmPrinterInlineAsm.cpp:147 is now just a white space change now.

 /// Current MCTargetOptions.
 MCTargetOptions MCOptions;

Without a set method the comment is out of date.

Nit: maybe even better than a copy would be a const reference if that
is possible.

LGTM with that.


  Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe.

More information about the llvm-commits mailing list