[patch] mergefunc struct result

Carlo Kok ck at remobjects.com
Tue Apr 22 00:45:46 PDT 2014


On Sun, 20 Apr 2014 01:50:49 +0200, Duncan P. N. Exon Smith  
<dexonsmith at apple.com> wrote:

>>
>> In this case no, the function works on ints and pointers now:
>
> For clarity, I mean:
>
>     if (SrcTy->isStructTy()) {
>       assert(DestTy->isStructTy() && "Can only cast SrcTy to StructTy");
>       // ...
>     }
>     assert(!DestTy->isStructTy() && "Cannot cast SrcTy to StructTy");
>


Ah that makes more sense. Attached is a version with all your suggestions  
integrated & clang formatted. The only issue I had was that from within  
Visual Studio the testcases refused to test at all:

20>  WindowsError: [Error 193] %1 is not a valid Win32 application  
(TaskId:167)

I did run the opt/filecheck commands manually before and after and it  
properly failed (before) and succeeded after.

-- 
Carlo Kok
RemObjects Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-mergefunc-struct-result-2.diff
Type: application/octet-stream
Size: 2753 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140422/0ac09bae/attachment.obj>


More information about the llvm-commits mailing list