R600/SI: Prettier display of input modifiers and fold of fabs
Daenzer, Michel
Michel.Daenzer at amd.com
Mon Apr 21 18:44:42 PDT 2014
On Mon, 2014-04-21 at 14:39 -0700, Vincent Lejeune wrote:
>
> > Did piglit run all tests up to and including OpenGL 3.3 / GLSL 3.30?
>
> Yes, there is no issue with GS.
Great.
> > Would it be possible to completely remove the printing of the
> modifier
> > arguments separately?
>
> I don't understand what you mean.
Never mind, I was confusing input and output modifiers.
> +; SI-CHECK-LABEL: @fneg_fabs_fold
> +
> +define void @fneg_fabs_fold(float addrspace(1)* %out, float %in, float %in2) {
This should also check that the modifiers are used as expected.
Other than that, these patches look good to me.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
More information about the llvm-commits
mailing list