[llvm] r206727 - Protect the ArgList dtor

Reid Kleckner rnk at google.com
Mon Apr 21 11:03:52 PDT 2014

On Mon, Apr 21, 2014 at 10:59 AM, David Blaikie <dblaikie at gmail.com> wrote:
> In 4.7 and above there's "-Wdelete-non-virtual-dtor" which is enabled
> by -Wall and warns at the delete which is more accurate.
> So long as we're dynamically allocating ArgLists, we'd either need to
> mark the concrete ArgLists as final (this correctly suppresses
> -Wdelete-non-virtual-dtor in GCC 4.7 and Clang)

+1 for using -Wdelete-non-virtual-dtor and marking the concrete classes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140421/d18bc422/attachment.html>

More information about the llvm-commits mailing list