[PATCH] PR18921, vmov part

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Apr 21 07:56:28 PDT 2014

Comment at: lib/Target/ARM/ARMInstrNEON.td:5347
@@ -5303,1 +5346,3 @@
+// Catch cases when assembler generator (usually gcc) emitted
+// incorrect instruction but with clear intention to setup all ones, e.g.:
"assembly generator", no?

In any case, it is not really relevant in the assembly is generated or user written. Just say that we (and gas) support this extension.

The comment is also out of date since the code now supports 0xabab for example.

Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:1640
@@ +1639,3 @@
+  bool isNEONByteReplicate(unsigned NumBytes) const {
+    if (!isImm()) return false;
+    const MCConstantExpr *CE = dyn_cast<MCConstantExpr>(getImm());
please clang-format the patch.


More information about the llvm-commits mailing list