[PATCH] MachineFunction is exposed to X86AsmParser.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Apr 21 07:35:57 PDT 2014



================
Comment at: include/llvm/MC/MCTargetOptions.h:15
@@ +14,3 @@
+
+class MCTargetOptions {
+public:
----------------
Do you expect this class to grow? Why have a class with only one field?

================
Comment at: lib/MC/MCTargetOptions.cpp:21
@@ +20,3 @@
+
+cl::opt<AsmInstrumentationMode> ClAsmInstrumentation(
+    "asm-instrumentation", cl::desc("Instrumentation of inline assembly and "
----------------
We normally don't want to have command line options showing up in a binary just because it it links with MC. Can this be added to just llc and llvm-mc? Maybe add the option to CommandFlags.h or create another similar file for MC?

================
Comment at: include/llvm/MC/MCTargetAsmParser.h:102
@@ +101,3 @@
+  /// Current MCTargetOptions.
+  const MCTargetOptions *MCOptions;
+
----------------
Can this go on the asm streamer?


http://reviews.llvm.org/D3106






More information about the llvm-commits mailing list