[llvm] r206581 - [LCG] Add support for building persistent and connected SCCs to the

[Chandler Carruth]

On Fri, Apr 18, 2014 at 7:20 AM, Benjamin Kramer <benny.kra at gmail.com>wrote:

> > +  /// \brief Counter for the next DFS number to assign.
> > +  int NextDFSNumber;
>
> This member var isn't initialized anywhere. MSan and valgrind are upset.
>

Ow, good catch.


> > LazyCallGraph::LazyCallGraph(LazyCallGraph &&G)
> >     : BPA(std::move(G.BPA)), EntryNodes(std::move(G.EntryNodes)),
> > -      EntryNodeSet(std::move(G.EntryNodeSet)) {
> > +      EntryNodeSet(std::move(G.EntryNodeSet)),
> SCCBPA(std::move(G.SCCBPA)),
> > +      SCCMap(std::move(G.SCCMap)), LeafSCCs(std::move(G.LeafSCCs)),
> > +      DFSStack(std::move(G.DFSStack)),
> > +      SCCEntryNodes(std::move(G.SCCEntryNodes)) {
>
> The ctor misses two members, NodeMap and NextDFSNumber. Intentional?
>
> Same for the move assignment operator.
>

Doh! Definitely a bug.

Committed fixes to both in r206646. Thanks for the review!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140418/bbdc852b/attachment.html>