[llvm] r206565 - Patch by Ray Donnelly.

[Chandler Carruth]

I found the review thread for this and commented there, however there is a
greater problem. Ray Donnelly did not contribute this patch to LLVM in any
way. You cannot apply patches unless the *author* of the code contributes
it. Please see the developer's policy which has a section directly
addressing this:
http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes

I'm going to revert this and the related patches immediately just to get
the tree into a clean state. This isn't any kind of punishment, it is just
incredibly important that we only ever have patches in the tree that were
contributed openly and according to our developer policy.


On Fri, Apr 18, 2014 at 2:27 AM, Chandler Carruth <chandlerc at google.com>wrote:

> Yaron, this patch never got reviewed on the list. There was no LGTM, and
> certainly none of the maintainers of MC looked at it. Please revert and
> wait for proper review before committing.
>
>
> On Fri, Apr 18, 2014 at 1:03 AM, Yaron Keren <yaron.keren at gmail.com>wrote:
>
>> Author: yrnkrn
>> Date: Fri Apr 18 03:03:38 2014
>> New Revision: 206565
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=206565&view=rev
>> Log:
>> Patch by Ray Donnelly.
>>
>> Emit WIN64 SEH registers by name instead of just number.
>>
>>
>> Modified:
>>     llvm/trunk/lib/MC/MCAsmStreamer.cpp
>>
>> Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206565&r1=206564&r2=206565&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)
>> +++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Fri Apr 18 03:03:38 2014
>> @@ -1257,14 +1257,17 @@ void MCAsmStreamer::EmitWin64EHHandlerDa
>>  void MCAsmStreamer::EmitWin64EHPushReg(unsigned Register) {
>>    MCStreamer::EmitWin64EHPushReg(Register);
>>
>> -  OS << "\t.seh_pushreg " << Register;
>> +  OS << "\t.seh_pushreg ";
>> +  EmitRegisterName(Register);
>>    EmitEOL();
>>  }
>>
>>  void MCAsmStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned
>> Offset) {
>>    MCStreamer::EmitWin64EHSetFrame(Register, Offset);
>>
>> -  OS << "\t.seh_setframe " << Register << ", " << Offset;
>> +  OS << "\t.seh_setframe ";
>> +  EmitRegisterName(Register);
>> +  OS << ", " << Offset;
>>    EmitEOL();
>>  }
>>
>> @@ -1278,14 +1281,18 @@ void MCAsmStreamer::EmitWin64EHAllocStac
>>  void MCAsmStreamer::EmitWin64EHSaveReg(unsigned Register, unsigned
>> Offset) {
>>    MCStreamer::EmitWin64EHSaveReg(Register, Offset);
>>
>> -  OS << "\t.seh_savereg " << Register << ", " << Offset;
>> +  OS << "\t.seh_savereg ";
>> +  EmitRegisterName(Register);
>> +  OS << ", " << Offset;
>>    EmitEOL();
>>  }
>>
>>  void MCAsmStreamer::EmitWin64EHSaveXMM(unsigned Register, unsigned
>> Offset) {
>>    MCStreamer::EmitWin64EHSaveXMM(Register, Offset);
>>
>> -  OS << "\t.seh_savexmm " << Register << ", " << Offset;
>> +  OS << "\t.seh_savexmm ";
>> +  EmitRegisterName(Register);
>> +  OS << ", " << Offset;
>>    EmitEOL();
>>  }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140418/cb49da85/attachment.html>