[PATCH] [ELF] Support --defsym=<symbol>=<symbol>.

Rui Ueyama ruiu at google.com
Thu Apr 17 16:40:59 PDT 2014


On Thu, Apr 17, 2014 at 7:42 AM, Simon Atanasyan <simon at atanasyan.com>wrote:

>
>
> ================
> Comment at: include/lld/ReaderWriter/ELFLinkingContext.h:235
> @@ -230,1 +234,3 @@
>
> +  const std::map<std::string, std::string> getAliases() const {
> +    return _aliasSymbols;
> ----------------
> I think it is a typo here. The map should be returned be reference not
> value.


Thank you for finding this! This is indeed a typo, and that's actually the
cause of the FreeBSD test issue (I have spent quite a bit of time to nail
it down, I should have fixed this first and then started working on the
FreeBSD test failure).


>
> http://reviews.llvm.org/D3332
>
> BRANCH
>   alias
>
> ARCANIST PROJECT
>   lld
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140417/6f8d8672/attachment.html>


More information about the llvm-commits mailing list