[PATCH] blockfreq: Rewrite block frequency analysis

Chandler Carruth chandlerc at google.com
Thu Apr 17 14:20:45 PDT 2014


On Fri, Apr 11, 2014 at 5:00 PM, Andrew Trick <atrick at apple.com> wrote:

> > <block-frequency-20140411.patch>
>
> Thanks. I’m fine if you continue working on this in-tree since you're
> tracking performance.
>
> At this point, we mainly want to
> - simplify the code by moving helper code into support or eliminating the
> need for it (especially PositiveFloat)
> - add the block bias computation and API
> - maybe do a little better on irreducible CFGs
>

LGTM too.

I've looked through the patch, and almost all of the comments are things
that really shouldn't be dealt with until the simplifying is done.
(stylistic stuff like, using detail namespaces, etc. all of it likely to
fall out natrually of the simplifications, no point spending time on it now)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140417/d6639200/attachment.html>


More information about the llvm-commits mailing list