[PATCH] Fix bug 19437 - Only add discriminators for DWARF 4 and above.

[Eric Christopher]

On Thu, Apr 17, 2014 at 1:45 PM, Diego Novillo <dnovillo at google.com> wrote:
>
>
>
> On Thu, Apr 17, 2014 at 4:11 PM, Chandler Carruth <chandlerc at gmail.com>
> wrote:
>>
>>
>>
>> ================
>> Comment at: include/llvm/Support/Dwarf.h:957
>> @@ +956,3 @@
>> +/// Return Dwarf Version by checking module flags.
>> +inline unsigned getDwarfVersionFromModule(const Module *M) {
>> +  Value *Val = M->getModuleFlag("Dwarf Version");
>> ----------------
>> David Blaikie wrote:
>> > This might be worth being out of line, maybe. Not a big deal.
>> As Eric was indicating, this can't be in Support. I think this should be a
>> method on Module personally. It needs to be somewhere in the IR library at
>> least.
>>
> I'm not quite sure what to do with the default value, however. Ultimately, I
> need to return llvm::dwarf::DWARF_VERSION, which ties the IR/Module.cpp with
> Support/Dwarf.h.
>

IR should be able to depend upon support all it wants. :)