[PATCH] `nonnull` argument attribute.

hfinkel at anl.gov hfinkel at anl.gov
Wed Apr 16 04:32:25 PDT 2014


  Thanks for working on this!

  When uploading a patch to phabricator, please increase the number of context lines as documented here: http://llvm.org/docs/Phabricator.html


================
Comment at: test/Analysis/BasicAA/nonnull.ll:1
@@ +1,2 @@
+; RUN: opt < %s -basicaa -gvn -instcombine -S | FileCheck %s
+
----------------
This test is in the wrong place. You seem to be testing instcombine here, not basicaa, and so the test should be in test/Transforms/InstCombine somewhere.


http://reviews.llvm.org/D3389






More information about the llvm-commits mailing list