[PATCH] InlineFunction doesn't update InlineFunctionInfo with allocas created for byval arguments

Manman Ren manman.ren at gmail.com
Mon Apr 14 20:34:53 PDT 2014


LGTM.

Thanks,
Manman


On Mon, Apr 14, 2014 at 11:42 AM, Julien Lerouge <jlerouge at apple.com> wrote:

>
>
>
> On Fri, Apr 11, 2014 at 12:41:54PM -0700, Manman Ren wrote:
> > Hi Julien,
> >
> > The updated patch looks good overall.
> > Since there is refactoring going on, can you separate to two patches, one
> > with refactoring but no functionality change, to make review easier?
> >
> > Thanks,
> > Manman
> >
>
> Hello,
>
> Attached inline_001.diff that splits the byval argument initialization,
> and inline_002.diff that adds the marker for the byval induced allocas
> and test case.
>
> Let me know if there is anything else.
>
> Thanks again,
> Julien
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140414/f464060c/attachment.html>


More information about the llvm-commits mailing list