[PATCH] Debug Info Verifier pass

[Eric Christopher]

On Mon, Apr 14, 2014 at 5:56 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
> On Apr 11, 2014, at 11:31 AM, Manman Ren <manman.ren at gmail.com> wrote:
>
>> Hi Duncan,
>>
>> Thanks for working on this. The patches look great overall.
>> 0001: LGTM
>> 0002: There is some inconsistency in creating debug info verifier pass.
>> 1>
>> tools/opt/opt.cpp:  if (VerifyEach) PM.add(createVerifierPass());
>> Should VerifyEach guard debug info verifier as well given that we are using NoVerify to guard debug info verifier?
>> I am okay with not using VerifyEach for debug info verifier, but please add comments there to explain why.
>
> I just changed it to line up with Verifier for now.  Probably it will
> be too slow, but if it is, we'll probably want to add a separate flag
> so we can --verify-di-each on demand.
>

*shrug* I'm not too worried about it.

>
> Is this expected?  Given that I know next to nothing about debug
> info, I'm probably not the right person to diagnose them.

Seems reasonable. We've updated a lot of tests as we go along, but not
all of them.

>
> Should they be fixed before commit?  I'm thinking it would be
> better to tackle them incrementally.
>

Don't worry about that. If you want it to be on by default with
+Asserts then you'll need to make them clean.

Out of curiosity is projects/test-suite clean with this on?

-eric