[llvm] r206211 - [ARM64][MC] Set the default CPU to cyclone when initilizating the MC layer.

[Eric Christopher]

Thanks!

I'd probably see the ARM one as closer... it doesn't cope well if
there's no cpu given it doesn't look like :)

-eric

On Mon, Apr 14, 2014 at 3:00 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> Sorry, I thought I was doing the same thing as X86 here.
> I’ve been misled by this sequence:
> MCSubtargetInfo *X86_MC::createX86MCSubtargetInfo(StringRef TT, StringRef
> CPU,
>                                                   StringRef FS) {
> [...]
>   std::string CPUName = CPU;
>   if (CPUName.empty()) {
> #if defined(i386) || defined(__i386__) || defined(__x86__) ||
> defined(_M_IX86)\
>     || defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)
>     CPUName = sys::getHostCPUName();
> #else
>     CPUName = "generic";
> #endif
>   }
>
> Let me rework my copy then!
>
> -Quentin
>
> On Apr 14, 2014, at 2:42 PM, Eric Christopher <echristo at gmail.com> wrote:
>
> Uh, what?
>
> How about taking the same code from the ARM or X86 backends? Or something
> else?
>
> -eric
>
> On Mon, Apr 14, 2014 at 2:25 PM, Quentin Colombet <qcolombet at apple.com>
> wrote:
>
> Author: qcolombet
> Date: Mon Apr 14 16:25:53 2014
> New Revision: 206211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=206211&view=rev
> Log:
> [ARM64][MC] Set the default CPU to cyclone when initilizating the MC layer.
> This matches that ARM64Subtarget does for now.
>
> This is related to <rdar://problem/16573920>
>
> Modified:
>    llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp
>
> Modified: llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206211&r1=206210&r2=206211&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp
> (original)
> +++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp Mon Apr
> 14 16:25:53 2014
> @@ -43,6 +43,12 @@ static MCInstrInfo *createARM64MCInstrIn
> static MCSubtargetInfo *createARM64MCSubtargetInfo(StringRef TT, StringRef
> CPU,
>                                                    StringRef FS) {
>   MCSubtargetInfo *X = new MCSubtargetInfo();
> +
> +  // FIXME: Make this darwin-only.
> +  if (CPU.empty())
> +    // We default to Cyclone for now, on Darwin.
> +    CPU = "cyclone";
> +
>   InitARM64MCSubtargetInfo(X, TT, CPU, FS);
>   return X;
> }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>