[llvm] r205990 - Reimplement debug info compression by compressing the whole section, rather than a fragment.

[David Blaikie]

On Fri, Apr 11, 2014 at 2:59 PM, Eric Christopher <echristo at gmail.com> wrote:
> Looks great, couple of comments:
>
> a) long lines :)

Oh, right - r206078

> b)
>
>> +  Map.erase(SectionGroupPair(Section->getSectionName(), GroupName));
>> +  auto I = Map.insert(std::make_pair(SectionGroupPair(Name, GroupName),
>> +                                     Section)).first;
>> +  const_cast<MCSectionELF*>(Section)->setSectionName(I->first.first);
>> +}
>> +
>>
>
> Lifetime here is subtle, perhaps a comment that you want the actual string here?

Updated cases for all 3 (COFF, ELF, and ELF renaming) by introducing a
named local "CachedName" that's hopefully sufficiently self
documenting. I can add comments in too if you think it helps/is worth
it. r206080