[llvm] r205182 - llvm/test/MC/Mips/mips64r2/valid-xfail.s: This REQUIRES asserts. Seems it doesn't fail with -Asserts.

[NAKAMURA Takumi]

Seems fine. Thanks!

2014-04-12 0:43 GMT+09:00 Daniel Sanders <Daniel.Sanders at imgtec.com>:
> I've just reverted this commit to see if the problem still exists after rewriting the assembly parser and eliminating some uses of uninitialized values. I'll be watching the buildbots to see if any of them fail again.
>
>> -----Original Message-----
>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> bounces at cs.uiuc.edu] On Behalf Of Daniel Sanders
>> Sent: 31 March 2014 18:08
>> To: NAKAMURA Takumi; llvm-commits at cs.uiuc.edu
>> Subject: RE: [llvm] r205182 - llvm/test/MC/Mips/mips64r2/valid-xfail.s: This
>> REQUIRES asserts. Seems it doesn't fail with -Asserts.
>>
>> One of the buildbots detected use of an uninitialized value in MipsAsmParser
>> while processing several of the valid-xfail.s's. I assume it's something to do
>> with that. I'm going to commit a patch soon that rewrites the code concerned
>> so I'm not going to investigate it straight away. We'll see if the problem
>> remains after my commit.
>>
>> > -----Original Message-----
>> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> > bounces at cs.uiuc.edu] On Behalf Of NAKAMURA Takumi
>> > Sent: 31 March 2014 14:30
>> > To: llvm-commits at cs.uiuc.edu
>> > Subject: [llvm] r205182 - llvm/test/MC/Mips/mips64r2/valid-xfail.s:
>> > This REQUIRES asserts. Seems it doesn't fail with -Asserts.
>> >
>> > Author: chapuni
>> > Date: Mon Mar 31 08:30:02 2014
>> > New Revision: 205182
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=205182&view=rev
>> > Log:
>> > llvm/test/MC/Mips/mips64r2/valid-xfail.s: This REQUIRES asserts. Seems
>> > it doesn't fail with -Asserts.
>> >
>> > Modified:
>> >     llvm/trunk/test/MC/Mips/mips64r2/valid-xfail.s
>> >
>> > Modified: llvm/trunk/test/MC/Mips/mips64r2/valid-xfail.s
>> > URL: http://llvm.org/viewvc/llvm-
>> > project/llvm/trunk/test/MC/Mips/mips64r2/valid-
>> > xfail.s?rev=205182&r1=205181&r2=205182&view=diff
>> >
>> ==========================================================
>> > ====================
>> > --- llvm/trunk/test/MC/Mips/mips64r2/valid-xfail.s (original)
>> > +++ llvm/trunk/test/MC/Mips/mips64r2/valid-xfail.s Mon Mar 31 08:30:02
>> > +++ 2014
>> > @@ -5,6 +5,7 @@
>> >  # RUN: not llvm-mc %s -triple=mips64-unknown-linux -show-encoding -
>> > mcpu=mips64r2 | not FileCheck %s  # CHECK-NOT: encoding  # XFAIL: *
>> > +# REQUIRES: asserts
>> >
>> >     .set noat
>> >     abs.ps  $f22,$f8
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits