[PATCH] Move the segmented stack switch to a function attribute

Peter Collingbourne peter at pcc.me.uk
Thu Apr 10 16:30:48 PDT 2014


On Thu, Apr 10, 2014 at 04:07:13PM -0700, Reid Kleckner wrote:
> On Thu, Apr 10, 2014 at 3:56 PM, Alex Crichton <alex at crichton.co> wrote:
> 
> > > Looks good, but this will require changes to clang to support
> > -fsplit-stack.
> > > Could you send a companion patch to update clang?
> >
> > I can indeed, a patch is attached.
> 
> 
> Committed in r205997 and r205998.  Thanks!
> 
> 
> > > Are there any other major frontends using split stacks that we should
> > > notify?
> >
> > I can deal with Rust, and nothing else comes to mind, but I'm probably
> > also not the right candidate for knowing this information...
> >
> 
> My only best guess is llgo, but I couldn't find any instances of
> EnableSegmentedStacks in https://github.com/go-llvm/.

The branch of llgo that is currently under development can currently only
compile small test cases, so we've been able to get away with not enabling
split stacks.

The feature will need to be turned on soon though, and definitely on a
per-function basis (in order to allow for whole-program optimization with
the libgo standard library, which contains some functions which need split
stacks disabled) -- thanks for the heads up.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list