[PATCH] Rename enums in Support/MachO.h

[Nick Kledzik]

On Apr 8, 2014, at 5:18 PM, Reid Kleckner wrote:

> I thought this came up before and the answer was "it's a feature, not a bug", but maybe Nick remembers.
Yes.  We want LLVM to use the standard/documented names.

I thought LLVM code was supposed to only include LLVM headers.  That assures that the code will build on all platforms.  

At some point (in rare instances) you have OS specific code (e.g. llvm/lib/Support/Unix/Process.inc), and that code does the careful dance with how to include OS and LLVM headers.

-Nick


> 
> 
> On Tue, Apr 8, 2014 at 3:12 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:
> The attached patch renames enums in Support/MachO.h. This is needed because some of the enum names are taken directly from system header files and including both MachO.h and some internal versions of those system header files causes name collisions.
> 
> With this patch, we can stop using the following workaround that was required to build lldb:
>  
> http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140331/010905.html
> 
> Please review.
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140408/f62583a0/attachment.html>