delinearization

[Tobias Grosser]

On 04/08/2014 11:38 PM, Sebastian Pop wrote:
> Tobias Grosser wrote:
>> On 04/04/2014 11:06 PM, Sebastian Pop wrote:
>>> Hi,
>>>
>>> here is the updated version of the patch that passes all the make check-polly
>>> tests: yay! (I don't have cloog around, so I haven't checked those tests.)
>>
>> The cloog tests need to be updated. There are three solutions
>>
>> 1) We write a clang-cmp tool that does this semantically
>> 2) You install it briefly and update the tests
>
> I installed cloog and checked with it before I committed the patch.
> All tests are passing.

Nice.

> However, when I enable delinearization by default, 2 cloog tests are failing:
> Tobi, could you please have a look at these two?
>
> test/Cloog/CodeGen/matmul_vec.ll
> test/Cloog/CodeGen/MemAccess/codegen_simple_md.ll
>
> These are failing with a JScop error complaining about inconsistent array access
> functions (or something else...)

I will check.

>> 3) You commit and I fix later.
>>
>> I would prefer 1), understand that 2) is easier and if necessary, we
>> can also go for 3).
>>
>>> The only changes wrt. previous patch are:
>>> - add a flag -polly-delinearize (similar to -da-delinearize)
>>> - normalize the last subscript with respect to the size of elements in the array.
>>
>> Nice, that this fixed the remaining issues.
>>
>>> Ok to commit?
>>
>> Yes, despite the CLooG test cases this looks good.
>
> No cloog tests were failing on my side, so our build bots should be happy with
> my last commit.

They have besides formatting.

> I have started triaging the bugs in the nightly test-suite when enabling
> -polly-delinearization.  I have fixed a couple of bugs already: that just shows
> that all this code was never really tested...  I will continue a bit on fixing
> everything that fails in SCEV->delinearize and on the -polly-delinearize side.

Nice.

Thanks a lot,
Tobias