[PATCH] WinCOFF: Emit common symbols as specified in the COFF spec

David Majnemer david.majnemer at gmail.com
Tue Apr 8 13:38:29 PDT 2014


Hi Bigcheese, rafael, rnk,

Local common symbols were properly inserted into the .bss section.
However, putting external common symbols in the .bss section would give
them a strong definition.

Instead, encode them as undefined, external symbols who's symbol value
is equivalent to their size.

http://reviews.llvm.org/D3324

Files:
  lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  lib/MC/MCObjectFileInfo.cpp
  lib/MC/WinCOFFObjectWriter.cpp
  lib/MC/WinCOFFStreamer.cpp
  test/MC/COFF/comm.ll
  test/MC/COFF/comm.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3324.1.patch
Type: text/x-patch
Size: 6825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140408/7db9b105/attachment.bin>


More information about the llvm-commits mailing list