[PATCH] InlineFunction doesn't update InlineFunctionInfo with allocas created for byval arguments

Manman Ren manman.ren at gmail.com
Tue Apr 8 10:30:44 PDT 2014


On Fri, Apr 4, 2014 at 5:15 PM, Julien Lerouge <julien.lerouge at m4x.org>wrote:

> When llvm::InlineFunction inlines a function that has byval arguments,
> it creates allocas in the caller. Those allocas aren't inserted in the
> InlineFunctionInfo data structure. So after inlining, if the client code
> wants to know where are the allocas that were created, it will miss
> those.
>
> Should InlineFunctionInfo contain these allocas, or is the omission
> deliberate ?
>

Hi Julien,

I don't think the omission is deliberate, but I may be wrong.
Do you have a testing case?

Thanks,
Manman


>
> The attached patch adds these new allocas.
>
> Thanks,
> Julien
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140408/2c5163ae/attachment.html>


More information about the llvm-commits mailing list