[PATCH] [yaml2obj] ELF Relocations Support

Sean Silva chisophugis at gmail.com
Mon Apr 7 16:29:54 PDT 2014


  LGTM.

  The duplication between Elf_Rel and Elf_Rela is a bit disturbing but I can't think of a significantly better way to do it. The best I can think of is to skip putting Elf_Rel{,a} in a std::vector (and calling writeArrayData) and directly output to the OS in buildRelocationArray (which would have to be renamed); that would let you push the distinction between Rel and Rela way down to the inner loop, but I'm not sure if that would end up being simpler.

http://reviews.llvm.org/D3302






More information about the llvm-commits mailing list