[PATCH] [ELF] Fix undefined symbol handling in DSO.

[Rui Ueyama]

On Mon, Apr 7, 2014 at 8:26 AM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   I am having some problem with my browser, with inline comments.  and I
> also think this be converted to 2 patches.
>
>   a) to remove the option (use-shlib-undefines)
>   b) fix --[no]allow-shlib-undefined.
>

My bet is --use-shlib-undefines was introduced to deal with undefined
symbols in a library file, under an incorrect assumption on how GNU LD
works on them. So fixing it naturally linked to removing the option.
Technically I can split this change into two parts; one to fix the issue
and leave code for --use-shlib-undefined as dead one, and remove it in a
followup patch. Not sure it worth doing, but if everybody wants it, I'll do
that.

  I am not sure the reason we added the option use-shlib-undefines,
> Bigcheese ?
>
>   Rui, can you wait on Bigcheese's review before removing the option
> use-shlib-undefines ?


Sure, of course.


>  http://reviews.llvm.org/D3304
>
> BRANCH
>   shlib
>
> ARCANIST PROJECT
>   lld
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140407/10f1047f/attachment.html>