[PATCH] [ELF] Fix undefined symbol handling in DSO.

Simon Atanasyan simon at atanasyan.com
Mon Apr 7 02:55:13 PDT 2014



================
Comment at: lib/Driver/GnuLdDriver.cpp:178
@@ -180,1 +177,3 @@
+    opts->registry().addSupportELFDynamicSharedObjects(opts->targetHandler());
+  return link(*opts, diagnostics);
 }
----------------
It's a bit hard to understand that there is no functional changes here and the only code modification is a variable renaming. Maybe move such changes to the separate commit?

================
Comment at: test/elf/dynamic-undef.test:23
@@ -22,3 @@
-RUN:   %p/Inputs/shared.so-x86-64 -o %t -e main -shared \
-RUN: --use-shlib-undefines --no-allow-shlib-undefined  2> %t2
-RUN: FileCheck -check-prefix=SHLIB %s < %t2
----------------
IMHO we still need to check that --no-allow-shlib-undefined disallows undefined symbols in a shared library and lld returns an error in this case.


http://reviews.llvm.org/D3304






More information about the llvm-commits mailing list