[PATCH] Add -pass-remarks flag to 'opt'.

[Diego Novillo]

On Fri, Apr 4, 2014 at 4:59 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>
> On Apr 4, 2014, at 1:40 PM, Diego Novillo <dnovillo at google.com> wrote:
>
>> On Fri, Apr 4, 2014 at 4:25 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>>
>>>  The question I am about to ask may be beyond the scope of this patch but is the option setting thread safe?
>>>  The implication is do we have to do something special to access and modify:
>>>  - OptimizationRemarkPattern.
>>>  - OptimizationRemarkExpr.
>>
>> It isn't, but neither is any of the other cl::opt handling code I've
>> seen elsewhere. Would you be OK with leaving it for a future patch?
> Sure, I just wanted to double check we are on the same page.
> Please file a PR for this when your patch lands.

Will do. I'm also curious as to how can I check for this. There is a
lot of other static state in the compiler. The LLVMContext setup seems
to be a way of dealing with that, but I could not use it for storage.
Options are processed at compiler startup time, which happens before
LLVMContext is brought up.

I'm not sure how I would even test for this. Suggestions?