[PATCH] Add -pass-remarks flag to 'opt'.

Quentin Colombet qcolombet at apple.com
Fri Apr 4 13:25:39 PDT 2014


  Hi Diego,

  The question I am about to ask may be beyond the scope of this patch but is the option setting thread safe?
  The implication is do we have to do something special to access and modify:
  - OptimizationRemarkPattern.
  - OptimizationRemarkExpr.

  Thanks,
  -Quentin


================
Comment at: lib/IR/LLVMContextImpl.cpp:53
@@ +52,3 @@
+/// LLVMContext::emitOptimizationRemark.
+static Regex *OptimizationRemarkPattern;
+
----------------
Add = NULL.
I am a bit paranoid with default initializer.


http://llvm-reviews.chandlerc.com/D3291

BRANCH
  pass-remarks-for-opt

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list