[patch, darwin-legacy] suppressing OS version asm directive

[David Fang]

Hi Jim,
 	But won't i386/x86_64-apple-darwin10 have the same problem? with 
its gcc-4.2-based toolchain?  I guess it all boils down to detecting (or 
assuming based on OS) characteristics of the cctools being used.  (I use 
-B to point to cctools that live outside the system compiler toolchain, 
for example.)  Iain, did you say you also observed this break on darwin11 
too?

David

> Hi David,
>
> I think we?re going to have to be a little more clever here. The intent 
> of these directives is to enable better build time diagnostics when 
> mixing and matching deployment targets that are older than the tools 
> being used. Perhaps we could disable if the target is ppc*-apple-darwin 
> instead?
>
> -Jim
>
> On Mar 27, 2014, at 4:56 PM, David Fang <fang at csl.cornell.edu> wrote:
>
>> Hi Jim,
>> 	A few weeks ago, you alerted us darwin-legacy users that r204190
>> 	and r204191 added a new asm directive that would break
>> 	compatibility with older cctools.  My regression testing found
>> 	that test/CodeGen/PowerPC/hello-reloc.ll had failed due to
>> 	different macho-dump, for instance. I took a stab at the attached
>> 	patch to suppress this new directive (guessing that OS X 10.9 is
>> 	the cut-off).  The patch restores my regression tests to their
>> 	previous state.  Does this seem like an adequate workaround for
>> 	legacy support?
>>
>> David
>>
>> --
>> David Fang
>> http://www.csl.cornell.edu/~fang/
>> <llvm-suppress-osversion-asm-directive.patch>
>

-- 
David Fang
http://www.csl.cornell.edu/~fang/