[lld] r205568 - Fix comments.
Rui Ueyama
ruiu at google.com
Thu Apr 3 14:06:24 PDT 2014
Author: ruiu
Date: Thu Apr 3 16:06:23 2014
New Revision: 205568
URL: http://llvm.org/viewvc/llvm-project?rev=205568&view=rev
Log:
Fix comments.
Modified:
lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h
lld/trunk/lib/Core/Resolver.cpp
lld/trunk/lib/ReaderWriter/ELF/Chunk.h
lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
lld/trunk/lib/ReaderWriter/ELF/ELFFile.h
lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
lld/trunk/lib/ReaderWriter/FileArchive.cpp
lld/trunk/unittests/DriverTests/InputGraphTest.cpp
Modified: lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h (original)
+++ lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h Thu Apr 3 16:06:23 2014
@@ -88,7 +88,7 @@ public:
}
bool validateImpl(raw_ostream &diagnostics) override;
- /// \brief Does the linker allow dynamic libraries to be linked with ?
+ /// \brief Does the linker allow dynamic libraries to be linked with?
/// This is true when the output mode of the executable is set to be
/// having NMAGIC/OMAGIC
virtual bool allowLinkWithDynamicLibraries() const {
@@ -129,7 +129,7 @@ public:
/// \brief Does the output have dynamic sections.
virtual bool isDynamic() const;
- /// \brief Are we creating a shared library ?
+ /// \brief Are we creating a shared library?
virtual bool isDynamicLibrary() const {
return _outputELFType == llvm::ELF::ET_DYN;
}
Modified: lld/trunk/lib/Core/Resolver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/Core/Resolver.cpp (original)
+++ lld/trunk/lib/Core/Resolver.cpp Thu Apr 3 16:06:23 2014
@@ -178,7 +178,7 @@ void Resolver::doUndefinedAtom(const Und
/// \brief Add the section group and the group-child reference members.
bool Resolver::maybeAddSectionGroupOrGnuLinkOnce(const DefinedAtom &atom) {
- // First time adding a group ?
+ // First time adding a group?
bool isFirstTime = _symbolTable.addGroup(atom);
if (!isFirstTime) {
Modified: lld/trunk/lib/ReaderWriter/ELF/Chunk.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Chunk.h?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Chunk.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Chunk.h Thu Apr 3 16:06:23 2014
@@ -73,7 +73,7 @@ public:
// Memory size of the chunk
uint64_t memSize() const { return _msize; }
void setMemSize(uint64_t msize) { _msize = msize; }
- // Whats the contentType of the chunk ?
+ // Whats the contentType of the chunk?
virtual int getContentType() const = 0;
// Writer the chunk
virtual void write(ELFWriter *writer, TargetLayout<ELFT> &layout,
Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Thu Apr 3 16:06:23 2014
@@ -600,7 +600,7 @@ template <class ELFT> void DefaultLayout
ScopedTask task(getDefaultDomain(), "assignSectionsToSegments");
ELFLinkingContext::OutputMagic outputMagic = _context.getOutputMagic();
// TODO: Do we want to give a chance for the targetHandlers
- // to sort segments in an arbitrary order ?
+ // to sort segments in an arbitrary order?
// sort the sections by their order as defined by the layout
std::stable_sort(_sections.begin(), _sections.end(),
[](Chunk<ELFT> *A, Chunk<ELFT> *B) {
@@ -702,7 +702,7 @@ template <class ELFT> void DefaultLayout
template <class ELFT> void DefaultLayout<ELFT>::assignFileOffsets() {
// TODO: Do we want to give a chance for the targetHandlers
- // to sort segments in an arbitrary order ?
+ // to sort segments in an arbitrary order?
std::sort(_segments.begin(), _segments.end(), Segment<ELFT>::compareSegments);
int ordinal = 0;
// Compute the number of segments that might be needed, so that the
Modified: lld/trunk/lib/ReaderWriter/ELF/ELFFile.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ELFFile.h?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ELFFile.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ELFFile.h Thu Apr 3 16:06:23 2014
@@ -605,7 +605,7 @@ template <class ELFT> error_code ELFFile
for (auto &i : _sectionSymbols) {
const Elf_Shdr *section = i.first;
- // Check if need to create atoms for this section ?
+ // Check if need to create atoms for this section?
if ((ignoreCreateAtomsForSection(section)))
continue;
Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Thu Apr 3 16:06:23 2014
@@ -429,7 +429,7 @@ public:
_virtualAddr = addr;
}
- // Is the section loadable ?
+ // Is the section loadable?
inline bool isLoadableSection() const { return _isLoadableSection; }
// Set section Loadable
Modified: lld/trunk/lib/ReaderWriter/FileArchive.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/FileArchive.cpp?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/FileArchive.cpp (original)
+++ lld/trunk/lib/ReaderWriter/FileArchive.cpp Thu Apr 3 16:06:23 2014
@@ -67,7 +67,7 @@ public:
return result[0].release();
}
- /// \brief Load all members of the archive ?
+ /// \brief Load all members of the archive?
virtual bool isWholeArchive() const { return _isWholeArchive; }
/// \brief parse each member
Modified: lld/trunk/unittests/DriverTests/InputGraphTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/InputGraphTest.cpp?rev=205568&r1=205567&r2=205568&view=diff
==============================================================================
--- lld/trunk/unittests/DriverTests/InputGraphTest.cpp (original)
+++ lld/trunk/unittests/DriverTests/InputGraphTest.cpp Thu Apr 3 16:06:23 2014
@@ -40,7 +40,7 @@ class MyExpandFileNode : public SimpleFi
public:
MyExpandFileNode(StringRef path) : SimpleFileNode(path) {}
- /// \brief How do we want to expand the current node ?
+ /// \brief How do we want to expand the current node?
bool shouldExpand() const override { return true; }
/// \brief Get the elements that we want to expand with.
More information about the llvm-commits
mailing list