[llvm] r205430 - ARM: Add support for segmented stacks

Oliver Stannard oliver.stannard at arm.com
Thu Apr 3 01:20:12 PDT 2014


Sorry, I must have missed that in the original thread. Is the fix as simple as changing that line to "__STACK_LIMIT"? If it is more complicated, I will revert the patch until we have decided how this should be implemented.

Oliver

> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 02 April 2014 19:32
> To: Oliver Stannard
> Cc: llvm-commits
> Subject: Re: [llvm] r205430 - ARM: Add support for segmented stacks
> 
> > +    ARMConstantPoolValue *NewCPV = ARMConstantPoolSymbol::Create(
> > +        MF.getFunction()->getContext(), "STACK_LIMIT", PCLabelId,
> 0);
> 
> I thought I'd already mentioned that this is incompatible with C.
> Someone could quite easily write "int STACK_LIMIT = 42;" in a program.
> 
> Tim.








More information about the llvm-commits mailing list