[llvm] r205514 - ARM64: don't generate __sincos_stret calls unless on MachO

Tim Northover tnorthover at apple.com
Thu Apr 3 00:06:13 PDT 2014


Author: tnorthover
Date: Thu Apr  3 02:06:13 2014
New Revision: 205514

URL: http://llvm.org/viewvc/llvm-project?rev=205514&view=rev
Log:
ARM64: don't generate __sincos_stret calls unless on MachO

This should fix PR19314.

Modified:
    llvm/trunk/lib/Target/ARM64/ARM64ISelLowering.cpp
    llvm/trunk/test/CodeGen/ARM64/sincos.ll

Modified: llvm/trunk/lib/Target/ARM64/ARM64ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/ARM64ISelLowering.cpp?rev=205514&r1=205513&r2=205514&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM64/ARM64ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/ARM64/ARM64ISelLowering.cpp Thu Apr  3 02:06:13 2014
@@ -351,11 +351,16 @@ ARM64TargetLowering::ARM64TargetLowering
 
   setOperationAction(ISD::PREFETCH, MVT::Other, Custom);
 
-  // For iOS, we don't want to the normal expansion of a libcall to
-  // sincos. We want to issue a libcall to __sincos_stret to avoid memory
-  // traffic.
-  setOperationAction(ISD::FSINCOS, MVT::f64, Custom);
-  setOperationAction(ISD::FSINCOS, MVT::f32, Custom);
+  if (Subtarget->isTargetMachO()) {
+    // For iOS, we don't want to the normal expansion of a libcall to
+    // sincos. We want to issue a libcall to __sincos_stret to avoid memory
+    // traffic.
+    setOperationAction(ISD::FSINCOS, MVT::f64, Custom);
+    setOperationAction(ISD::FSINCOS, MVT::f32, Custom);
+  } else {
+    setOperationAction(ISD::FSINCOS, MVT::f64, Expand);
+    setOperationAction(ISD::FSINCOS, MVT::f32, Expand);
+  }
 
   // ARM64 does not have floating-point extending loads, i1 sign-extending load,
   // floating-point truncating stores, or v2i32->v2i16 truncating store.

Modified: llvm/trunk/test/CodeGen/ARM64/sincos.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM64/sincos.ll?rev=205514&r1=205513&r2=205514&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM64/sincos.ll (original)
+++ llvm/trunk/test/CodeGen/ARM64/sincos.ll Thu Apr  3 02:06:13 2014
@@ -1,13 +1,19 @@
-; RUN: llc < %s -mtriple=arm64-apple-ios7 | FileCheck %s
+; RUN: llc < %s -mtriple=arm64-apple-ios7 | FileCheck %s --check-prefix CHECK-IOS
+; RUN: llc < %s -mtriple=arm64-linux-gnu | FileCheck %s --check-prefix CHECK-LINUX
 
 ; Combine sin / cos into a single call.
 ; rdar://12856873
 
 define float @test1(float %x) nounwind {
 entry:
-; CHECK-LABEL: test1:
-; CHECK: bl ___sincosf_stret
-; CHECK: fadd s0, s0, s1
+; CHECK-IOS-LABEL: test1:
+; CHECK-IOS: bl ___sincosf_stret
+; CHECK-IOS: fadd s0, s0, s1
+
+; CHECK-LINUX-LABEL: test1:
+; CHECK-LINUX: bl sinf
+; CHECK-LINUX: bl cosf
+
   %call = tail call float @sinf(float %x) nounwind readnone
   %call1 = tail call float @cosf(float %x) nounwind readnone
   %add = fadd float %call, %call1
@@ -16,9 +22,14 @@ entry:
 
 define double @test2(double %x) nounwind {
 entry:
-; CHECK-LABEL: test2:
-; CHECK: bl ___sincos_stret
-; CHECK: fadd d0, d0, d1
+; CHECK-IOS-LABEL: test2:
+; CHECK-IOS: bl ___sincos_stret
+; CHECK-IOS: fadd d0, d0, d1
+
+; CHECK-LINUX-LABEL: test2:
+; CHECK-LINUX: bl sin
+; CHECK-LINUX: bl cos
+
   %call = tail call double @sin(double %x) nounwind readnone
   %call1 = tail call double @cos(double %x) nounwind readnone
   %add = fadd double %call, %call1





More information about the llvm-commits mailing list