[PATCH] Convert getFileOffset to getOffset and move it to its only user.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Wed Apr 2 21:23:21 PDT 2014


Hi Bigcheese,

We normally don't drop functions from the C API's, but in this case I think we can:

* The old implementation of getFileOffset was fairly broken
* The introduction of LLVMGetSymbolFileOffset was itself a C api breaking change as it removed LLVMGetSymbolOffset
* It is an incredibly specialized use case. The only reason MCJIT needs it is because of its odd position of being a dynamic linker or .o files.


http://llvm-reviews.chandlerc.com/D3271

Files:
  bindings/python/llvm/object.py
  include/llvm-c/Object.h
  include/llvm/Object/ObjectFile.h
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
  lib/Object/Object.cpp
  tools/llvm-c-test/object.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3271.1.patch
Type: text/x-patch
Size: 7265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/0b505dcc/attachment.bin>


More information about the llvm-commits mailing list