[PATCH] Remove ordinals from Input Graph elements.

Rui Ueyama ruiu at google.com
Wed Apr 2 15:59:39 PDT 2014


Hi Bigcheese, shankarke, kledzik,

An ordinal is set to each child of Input Graph, but no one actually
uses it. The only piece of code that gets ordinaly values is
sortInputElements in InputGraph.cpp, but it does not actually do
anything -- we assign ordinals in increasing order just before
calling sort, so when sort is called it's already sorted. It's no-op.
We can simply remove it. No functionality change.

http://llvm-reviews.chandlerc.com/D3270

Files:
  include/lld/Core/InputGraph.h
  include/lld/Driver/GnuLdInputGraph.h
  include/lld/Driver/WinLinkInputGraph.h
  lib/Core/InputGraph.cpp
  lib/Driver/Driver.cpp
  lib/Driver/GnuLdDriver.cpp
  lib/Driver/GnuLdInputGraph.cpp
  test/Driver/libsearch-inputGraph.test
  unittests/DriverTests/InputGraphTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3270.1.patch
Type: text/x-patch
Size: 21326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/1f314d68/attachment.bin>


More information about the llvm-commits mailing list