[PATCH] R600: Make sign_extend_inreg legal.

Jan Vesely jan.vesely at rutgers.edu
Wed Apr 2 15:28:50 PDT 2014


Hi,

On Tue, 2014-04-01 at 11:34 -0700, Matt Arsenault wrote:
> I don't know why I didn't just do this before
> 
> http://llvm-reviews.chandlerc.com/D3250

I have two questions. I'm still learning llvm internals so pls bear with
me.

> +  if (!VT.isVector())
> +    return SDValue();

Is it possible to call the function on scalar types?
I assume the default is Legal, and the patch only changes it to expand for i1, i8, i16.

Also given that the LowerSIGN_EXTEND_INREG, how is it different from using setOperationAction(Expand)?
Is it kept around because of the EG TODO?

thank you,
Jan

PS: I apologize for not responding to that test request yet. These few weeks are rather busy for me.


> 
> Files:
>   lib/Target/R600/AMDGPUISelLowering.cpp
>   lib/Target/R600/EvergreenInstructions.td
>   lib/Target/R600/SIISelLowering.cpp
>   lib/Target/R600/SIInstructions.td
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/a7ac6029/attachment.sig>


More information about the llvm-commits mailing list