[PATCH] Simplify communication between Resolver and Input Graph.

Rui Ueyama ruiu at google.com
Wed Apr 2 13:37:05 PDT 2014


On Wed, Apr 2, 2014 at 1:32 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   Ah, the only problem that I see with this patch is how to add flavor
> specific looping inside a group.
>
>   For example:
>
>   With ELF, we want to search the group even if weak symbols were added.
> weak symbols are Defined Atoms.
>
>   When weak symbols are added, the group needs to be iterated as well.
>
>   A single boolean would not be enough.


I have not change the behavior, and I think the current code handles that
case. Look the last few lines in Resolver::handleFile.

 http://llvm-reviews.chandlerc.com/D3267
>
> BRANCH
>   cleanup
>
> ARCANIST PROJECT
>   lld
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/81a0540c/attachment.html>


More information about the llvm-commits mailing list