[PATCH] Add ARM big endian Target (armeb, thumbeb)

Tim Northover t.p.northover at gmail.com
Wed Apr 2 11:23:14 PDT 2014


Hi Christian,

>   There is no explicit test case for the getFixupKindContainerSizeBytes, but e.g. for function calls this function is relevant and implicit test cases are available.

This was actually my biggest concern with the patch. The names irked
me, but I could have lived with them. The undefined behaviour was
technically wrong but realistically going to be OK.

But I really would like to see testing of this relaxation code. I've
done an actual test where I mangle the values returned by that
function and no tests break. That's really not a good situation to be
in.

Cheers.

Tim.



More information about the llvm-commits mailing list