Optimising ARM DMBs

[Reinoud Elhorst]

Sorry Renato, I indeed skipped over your remark.

It's not entirely the same. A DMB is removable if the previous statement
was a DMB, or there has not been an instruction since the last DMB that
warrants a new DMB. PreviousIsDMB seems to suggest that we only look at the
previous instruction.

> It actually means "have I seen a DMB before" instead of "you can remove
the next DMB"

Actually it means "can I remove this instruction if it is a DMB", but I see
your point that IsRemovableNextDMB seems to make a promise towards any
subsequent DMB.

How about "seenDMBSinceLastMemoryAccess"? Although this encodes the logic
(that we can ignore instructions as far as dmbs are concerned based on
whether they have memory access) in the variable name, I don't really like
that either.

Claude


On Wed, Apr 2, 2014 at 9:03 AM, Renato Golin <renato.golin at linaro.org>wrote:

> On 2 April 2014 07:23, Tim Northover <t.p.northover at gmail.com> wrote:
> > I think this patch looks good now too. Do you have commit access or
> > would you like me to do it?
>
> I don't think he does. Reinoud, do you mind if we rename
> IsRemovableNextDMB to PreviousIsDMB before commit?
>
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/4ef05dae/attachment.html>