[lld] r205372 - Rename insertOneElementAt -> insertElementAt.
Rui Ueyama
ruiu at google.com
Tue Apr 1 16:17:28 PDT 2014
Author: ruiu
Date: Tue Apr 1 18:17:28 2014
New Revision: 205372
URL: http://llvm.org/viewvc/llvm-project?rev=205372&view=rev
Log:
Rename insertOneElementAt -> insertElementAt.
insertElementsAt() is removed, so "One" in insertOneElementAt() no longer
make much sense. Rename it for brevity.
Modified:
lld/trunk/include/lld/Core/InputGraph.h
lld/trunk/lib/Core/InputGraph.cpp
lld/trunk/lib/Driver/Driver.cpp
lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp
Modified: lld/trunk/include/lld/Core/InputGraph.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/InputGraph.h?rev=205372&r1=205371&r2=205372&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/InputGraph.h (original)
+++ lld/trunk/include/lld/Core/InputGraph.h Tue Apr 1 18:17:28 2014
@@ -48,7 +48,7 @@ public:
typedef FileVectorT::iterator FileIterT;
/// Where do we want to insert the input element when calling the
- /// insertElementAt, insertOneElementAt API's.
+ /// insertElementAt.
enum Position : uint8_t {
ANY,
BEGIN,
@@ -91,8 +91,8 @@ public:
}
/// \brief Insert an element into the input graph at position.
- void insertOneElementAt(std::unique_ptr<InputElement>,
- Position position, size_t pos = 0);
+ void insertElementAt(std::unique_ptr<InputElement>, Position position,
+ size_t pos = 0);
/// \brief Helper functions for the resolver
ErrorOr<InputElement *> getNextInputElement();
Modified: lld/trunk/lib/Core/InputGraph.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/InputGraph.cpp?rev=205372&r1=205371&r2=205372&view=diff
==============================================================================
--- lld/trunk/lib/Core/InputGraph.cpp (original)
+++ lld/trunk/lib/Core/InputGraph.cpp Tue Apr 1 18:17:28 2014
@@ -43,8 +43,8 @@ bool InputGraph::dump(raw_ostream &diagn
}
/// \brief Insert element at position
-void InputGraph::insertOneElementAt(std::unique_ptr<InputElement> element,
- Position position, size_t pos) {
+void InputGraph::insertElementAt(std::unique_ptr<InputElement> element,
+ Position position, size_t pos) {
if (position == InputGraph::Position::BEGIN)
pos = 0;
else if (position == InputGraph::Position::END)
Modified: lld/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/Driver.cpp?rev=205372&r1=205371&r2=205372&view=diff
==============================================================================
--- lld/trunk/lib/Driver/Driver.cpp (original)
+++ lld/trunk/lib/Driver/Driver.cpp Tue Apr 1 18:17:28 2014
@@ -96,8 +96,8 @@ bool Driver::link(LinkingContext &contex
if (implicitFiles.size())
fileNode->addFiles(std::move(implicitFiles));
- context.inputGraph().insertOneElementAt(std::move(fileNode),
- InputGraph::Position::BEGIN);
+ context.inputGraph().insertElementAt(std::move(fileNode),
+ InputGraph::Position::BEGIN);
context.inputGraph().assignOrdinals();
Modified: lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp?rev=205372&r1=205371&r2=205372&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp Tue Apr 1 18:17:28 2014
@@ -108,8 +108,7 @@ bool PECOFFLinkingContext::createImplici
std::unique_ptr<File> linkerGeneratedSymFile(
new pecoff::LinkerGeneratedSymbolFile(*this));
fileNode->appendInputFile(std::move(linkerGeneratedSymFile));
- inputGraph().insertOneElementAt(std::move(fileNode),
- InputGraph::Position::END);
+ inputGraph().insertElementAt(std::move(fileNode), InputGraph::Position::END);
return true;
}
More information about the llvm-commits
mailing list