[llvm] r205124 - X86Subtarget.h: isTargetWindows() should tell whether he is targeting msvc.

Aaron Ballman aaron at aaronballman.com
Tue Apr 1 07:03:56 PDT 2014


On Tue, Apr 1, 2014 at 9:52 AM, Yaron Keren <yaron.keren at gmail.com> wrote:
> To match the assert text, the condition should be
>
>   assert((Subtarget->isOSWindows() ||
>           getTargetMachine().Options.EnableSegmentedStacks) &&
>          "This should be used only on Windows targets or when segmented
> stacks "
>          "are being used");
>
> This may also fix the FAIL if the OS is windows but the target is not MSVC,
> GNU or Cygwin.

That's a sensible suggestion -- and it resolved the issue for me
locally. I've committed in r205313, and I'll see if the bots are happy
with it.

Thanks!

~Aaron



More information about the llvm-commits mailing list