[PATCH] Add support for optimization reports.

[Diego Novillo]

On Mon, Mar 31, 2014 at 8:19 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>
>   Hi Diego,
>
>   We are missing a test case here + a few minor things to check/fix.
>
>   Thanks,
>   -Quentin
>
>
> ================
> Comment at: include/llvm/Transforms/IPO/PassManagerBuilder.h:19
> @@ -18,2 +18,3 @@
>  #include <vector>
> +#include <string>
>
> ----------------
> Was this intended?
> I do not see any other changes that require that.

Fixed. Remnant of previous attempt.

> ================
> Comment at: lib/Transforms/IPO/Inliner.cpp:530
> @@ +529,3 @@
> +            DEBUG_TYPE, *Caller, CS.getInstruction()->getDebugLoc(),
> +            Twine(Callee->getName() + " inlined into " + Caller->getName()));
> +        Caller->getContext().diagnose(Diag);
> ----------------
> I'm not sure the lifetime of all the references you are using in Twine are long enough.
>
> Could you double check that the things are not freed before you are using it (like the fix we had to do in r203996)?

Silly me.  Fixed.


Thanks.  Diego.