[PATCH] Optional support for dynamic Asan runtime

[Alexey Samsonov]

  Awesome.


================
Comment at: lib/asan/asan_linux.cc:111
@@ +110,3 @@
+#if !SANITIZER_ANDROID
+#if ASAN_DYNAMIC
+  if (__asan_rt_version == ASAN_RT_VERSION_UNDEFINED) {
----------------
Could you use
  if (ASAN_DYNAMIC) {
    //...
  else {
    //...
  }
instead of #ifdef here? Also please add a comment describing why you need /proc/self/maps iteration.

================
Comment at: lib/asan/asan_rtl.cc:713
@@ +712,3 @@
+
+extern "C" {
+SANITIZER_INTERFACE_ATTRIBUTE
----------------
Do you still need these?

================
Comment at: test/asan/TestCases/Linux/interception_malloc_test.cc:13
@@ +12,3 @@
+extern "C"
+__attribute__((no_sanitize_address))  // Malloc may be called from dlsym in __asan_init
+void *malloc(size_t size) {
----------------
Is this still relevant?


http://llvm-reviews.chandlerc.com/D3042