Segmented Stack support for X64-MinGW

klutzy klutzytheklutzy at gmail.com
Mon Mar 31 21:36:12 PDT 2014


Hello, klutzy here. :)
I'm ok with committing the patch to upstream. Thanks for review!
2014/04/01 11:44 "Reid Kleckner" <rnk at google.com>:

> The patch looks good, and I'll commit if klutzy acknowledges on
> llvm-commits that they want it upstream.  I just want to comply with the
> attribution policy:
> http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes
>
> I'm not sure how wise it is to touch pvArbitrary, but hey, we do it for
> 32-bit.  *shrug*
>
>
> On Mon, Mar 31, 2014 at 5:04 PM, Alex Crichton <alex at crichton.co> wrote:
>
>> As part of the ongoing effort to upstream the patches that we're using
>> with the Rust language, this is a patch which adds support for
>> segmented stacks on 64-bit windows using MinGW. The original author
>> was @klutzy on GitHub [1], and I've just added some tests to it.
>>
>> The implementation is the same as the 32-bit windows implementation by
>> assuming that the stack limit is in the TIB's arbitrary data slot [2].
>> The location of the TIB is slightly different, being pointed to by %gs
>> instead of %fs [3].
>>
>> If anything else is required, please just let me know!
>>
>> [1] - https://github.com/rust-lang/llvm/commit/12d885
>> [2] - http://en.wikipedia.org/wiki/Win32_Thread_Information_Block
>> [3] - http://en.wikipedia.org/wiki/X86-64
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140401/11ab4a7a/attachment.html>


More information about the llvm-commits mailing list