[PATCH] [lld][core] support .gnu.linkonce sections

[Rui Ueyama]

  This looks nicer than the previous one. Some nits.

  Also please add "ruiu" when you use Phabricator in the future. "rui314" is not my address for LLVM code review.


================
Comment at: include/lld/Core/DefinedAtom.h:336
@@ +335,3 @@
+  /// that represents section groups or .gnu.linkonce sections.
+  bool isParentOfAGroup() const {
+    ContentType atomContentType = contentType();
----------------
"OfA" sounds a bit odd. I'd name isParentOfGroup or isGroupParent.

================
Comment at: lib/Core/Resolver.cpp:255
@@ -235,3 +254,3 @@
     _symbolTable.add(atom);
 
   if (_context.deadStrip()) {
----------------
Add '}' to this line and '{' at line 253.

================
Comment at: lib/Core/Resolver.cpp:250
@@ +249,3 @@
+      llvm::errs() << "SymbolTable: error while merging " << atom.name()
+                   << "\n";
+      llvm::report_fatal_error("duplicate symbol error");
----------------
This can be at end of the previous line.


http://llvm-reviews.chandlerc.com/D3242