[PATCH] XCore target: Add TypeString meta data to IR output.

[Eric Christopher]

  This needs the changes that Rafael mentioned as well as needing the format that you're emitting documented.

  Few other comments inline for now.


================
Comment at: test/CodeGen/xcore-stringtype.c:6
@@ +5,3 @@
+
+// We expect exactly 33 TypeStrings to be created. Thus unsupported Types are implicitly verified by there absence.
+// CHECK: !xcore.typestrings = !{!0, !1, !2, !3, !4, !5, !6, !7, !8, !9, !10, !11, !12, !13, !14, !15, !16, !17, !18, !19, !20, !21, !22, !23, !24, !25, !26, !27, !28, !29, !30, !31, !32}
----------------
"their"

Also why 33? Also what's supported/unsupported? It's not obvious from the comment in the testcase and would require someone knowing the entire scheme to debug.

================
Comment at: test/CodeGen/xcore-stringtype.c:35
@@ +34,3 @@
+void GVA(int i, ...) {EVA(i);}
+extern const volatile int* volatile restrict const
+    EQ(const volatile int * volatile restrict const);
----------------
It would be nice if the code in the testcase followed the llvm coding standard.


http://llvm-reviews.chandlerc.com/D2929