[PATCH] Fix LTO handling of symbols in the .symver directive

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sat Mar 29 08:32:13 PDT 2014


LGTM

On 27 March 2014 18:41, Tom Roeder <tmroeder at google.com> wrote:
> This patch fixes LTO's RecordStreamer so that it records symbols in the
> MCExpr part of an asm .symver directive as being used. This prevents
> referenced functions from being internalized and deleted.  This happens,
> e.g., in libaio (http://lse.sourceforge.net/io/aio.html).
>
> Without this patch, the attached test case will cause LLVM to produce the
> error:
>
> LLVM ERROR: A @@ version cannot be undefined.
>
> Please let me know what you think.
>
> Thanks,
>
> Tom
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list