[PATCH] [ELF] Support --defsym option to define an absolute symbol.
Shankar Kalpathi Easwaran
shankarke at gmail.com
Fri Mar 28 09:42:43 PDT 2014
Ok, I agree about that its more complex to have the complete --defsym option.
Once the above comment is fixed, this patch LGTM.
================
Comment at: lib/Core/LinkingContext.cpp:59-61
@@ -58,5 +58,5 @@
-std::unique_ptr<File> LinkingContext::createUndefinedSymbolFile() const {
- return createUndefinedSymbolFile("command line option -u");
+std::unique_ptr<File> LinkingContext::createCommandLineFile() const {
+ return createCommandLineFile("<command line option -u or --defsym>");
}
----------------
Can we use a separate string for -u and --defsym. We could have a createCommandLineFile with a StringRef like how PECOFF does, so that we can support more command line defined by various options.
http://llvm-reviews.chandlerc.com/D3208
BRANCH
defsym
ARCANIST PROJECT
lld
More information about the llvm-commits
mailing list