[PATCH] Optional support for dynamic Asan runtime

[Alexey Samsonov]

================
Comment at: lib/asan/asan_linux.cc:105
@@ +104,3 @@
+  if (dlsym(RTLD_DEFAULT, badsym)) {
+    Report("Your application is linked against "
+      "incompatible ASan runtimes.\n");
----------------
Yury Gribov wrote:
> Yury Gribov wrote:
> > Alexey Samsonov wrote:
> > > Consider running tools/clang/tools/clang-format/clang-format-diff.py on your patch.
> > Ok, good to know.
> Are you sure the tool is usable? I see some strange changes like
> 
> +extern "C" __attribute__((
> +    no_sanitize_address)) // Malloc may be called from dlsym in __asan_init
> +void *malloc(size_t size) {
> 
> and misplaced comments.
Hm. If this happens with fresh clang-format in your PATH, feel free to disregard it then.

================
Comment at: test/asan/CMakeLists.txt:66
@@ +65,3 @@
+  if(COMPILER_RT_BUILD_SHARED_ASAN)
+    set(ASAN_TEST_DYNAMIC True)
+    configure_lit_site_cfg(
----------------
Yury Gribov wrote:
> Here.
Yeah, running unit tests with dynamic runtime may be... challenging. Feel free to drop this part from the patch for now.


http://llvm-reviews.chandlerc.com/D3042