[PATCH] Remove LowerInvoke's obsolete "-enable-correct-eh-support" option

Rafael Espíndola rafael.espindola at gmail.com
Wed Mar 26 14:17:55 PDT 2014


On 26 March 2014 17:11, Mark Seaborn <mseaborn at chromium.org> wrote:
> On 20 March 2014 10:33, Rafael Ávila de Espíndola
> <rafael.espindola at gmail.com> wrote:
>>
>>   LGTM. It might be a good idea to rename the pass, but that can be done
>> in another patch.
>
>
> Do you have any recommendations about what to rename LowerInvoke to?  I
> agree that "lower" isn't a great name, since the pass is stripping out
> information irreversibly rather than lowering a feature while preserving
> behaviour.  How about "StripInvokes"?
>
> If we rename this, it would make sense to rename "LowerAtomic" to
> "StripAtomics" too, since that's another pass which strips out information
> irreversibly (like StripDeadPrototypes and StripSymbols).

Both names look good to me.

Cheers,
Rafael




More information about the llvm-commits mailing list