[llvm] r204766 - llvm/test/DebugInfo/empty.ll: Suppress crash for targeting pecoff while investigating.

[Eric Christopher]

On Tue, Mar 25, 2014 at 8:13 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Tue, Mar 25, 2014 at 7:13 PM, Eric Christopher <echristo at gmail.com> wrote:
>> On Mar 25, 2014 4:27 PM, "David Blaikie" <dblaikie at gmail.com> wrote:
>>>
>>> This is the "usual" problem with LLVM's COFF support not handling
>>> empty sections. I'm not sure what we've done about this in the past
>>> (perhaps there's an obvious fix where we add more careful handling so
>>> we don't try to touch those to-be-empty sections - I'm not sure which
>>> one's tickling it in this case).
>>
>>
>> Largely we've made sure that there's actually something there when we depend
>> on a section. The usual cause is a relocation against a section that ends up
>> not being emitted.
>
> Ah - easier than I figured. COFF just didn't have the DWO related
> section symbols... fixed in r204780.
>

I'm not sure this is the right fix really since there's no none way
for a COFF target to handle it - I don't know that I want an assert
necessarily but I don't see that we should emit sections that nothing
knows how to handle either. For split dwarf there really is only one
acceptable target right now.

-eric

>>
>> -eric
>>
>>>
>>>
>>> On Tue, Mar 25, 2014 at 4:16 PM, NAKAMURA Takumi <geek4civic at gmail.com>
>>> wrote:
>>> > Author: chapuni
>>> > Date: Tue Mar 25 18:16:44 2014
>>> > New Revision: 204766
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=204766&view=rev
>>> > Log:
>>> > llvm/test/DebugInfo/empty.ll: Suppress crash for targeting pecoff while
>>> > investigating.
>>> >
>>> > Modified:
>>> >     llvm/trunk/test/DebugInfo/empty.ll
>>> >
>>> > Modified: llvm/trunk/test/DebugInfo/empty.ll
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/empty.ll?rev=204766&r1=204765&r2=204766&view=diff
>>> >
>>> > ==============================================================================
>>> > --- llvm/trunk/test/DebugInfo/empty.ll (original)
>>> > +++ llvm/trunk/test/DebugInfo/empty.ll Tue Mar 25 18:16:44 2014
>>> > @@ -1,7 +1,7 @@
>>> >  ; REQUIRES: object-emission
>>> >
>>> >  ; RUN: %llc_dwarf < %s -filetype=obj | llvm-dwarfdump - | FileCheck %s
>>> > -; RUN: %llc_dwarf -split-dwarf=Enable < %s -filetype=obj |
>>> > llvm-dwarfdump - | FileCheck --check-prefix=FISSION %s
>>> > +; RUN: llc -mtriple=x86_64-unknown-unknown -split-dwarf=Enable < %s
>>> > -filetype=obj | llvm-dwarfdump - | FileCheck --check-prefix=FISSION %s
>>> >
>>> >  ; darwin has a workaround for a linker bug so it always emits one line
>>> > table entry
>>> >  ; XFAIL: darwin
>>> >
>>> >
>>> > _______________________________________________
>>> > llvm-commits mailing list
>>> > llvm-commits at cs.uiuc.edu
>>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits